User Reminder

Here my mods and history gets moved when validated and released to the phpbb.com MODDB

Re: User Reminder

Postby lefty » Wed Jul 16, 2008 11:24 pm

hi J.P.,
welcome to my board

it depends what they were reminded for. if it is for not posting that could still be that they get a second reminder.

I would need some more details what they were reminded for etc, i dont mind if u wrote dutch, i think i can figure out what you mean but i will reply in english (if i have an answer ;) )
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby J.P. » Thu Jul 17, 2008 8:34 am

Ok bedankt, ik heb...
Schakel automatische herinneringen in: op ja.
Krijgen geen e-mail: op ja.
Herinner gebruikers met 0 berichten .: op manueel want die gebruik ik niet.
Herinner inactieve gebruikers: automatisch en op 50.
Herinner actieve gebruikers, maar die nog nooit ingelogd zijn.: op manueel want die gebruik ik niet.
Herinner de gebruiker een tweede keer: op automatisch, Inactieve Gebruikers aangevinkt en op 5.

Het probleem is dus dat als ze een herinnering hebben gekregen en ze daarna wel inloggen en ik bij de lijst 2de herinnering de leden verwijder dat er dan ookleden verwijderd worden die na een herinnering hebben ontvangen in gelogd hebben ook verwijderd worden.

Groetjes, Jan...
J.P.
Newbie/Neuling
 
Posts: 5
Joined: Wed Jul 16, 2008 10:00 pm
Location: Netherlands, Groningen

Re: User Reminder

Postby lefty » Thu Jul 17, 2008 6:13 pm

strange, i will check that out and get back to you.
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby lefty » Thu Jul 17, 2008 8:19 pm

hi jp,
you said you were on version 1.0.0?

please upgrade to the latest version, the previous version had a little bug that it did not save the selection of tick boxes.

:happysmerk:
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby J.P. » Fri Jul 18, 2008 6:37 am

Ok i will upgrade it, so that can be the reasen that it also removed the members that had already login?
J.P.
Newbie/Neuling
 
Posts: 5
Joined: Wed Jul 16, 2008 10:00 pm
Location: Netherlands, Groningen

Re: User Reminder

Postby lefty » Fri Jul 18, 2008 7:14 am

from what i could see,the tick issue should have been cause of it.
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby madmax765 » Thu Jul 31, 2008 6:28 pm

Hi left i am curtenly using 0.2.1 i went and got your newest relase "user_reminder_1_0_1" so i went to folder user_reminder_1_0_1\user_reminder_1.0.1\contrib i open first file upgrade 021 to 100 to upgrade to 100 first before i went to upgrade 100 to 101, file upgrade 100 to 101 opens ok like the rest do,but file upgrade 021 to 100 dose not open right its all mesed up so i cant make heads or tails of what needs to be changed to go to next version, i even tryed to redown load it again just in case it was a bad down load, but its still curuped. Could you please fix then when you get time. Thank You

Oh where can i find the file that holds the info the reminder sends out. i like to change what it says, people are thinking im going to delete them. like to make it say like i am so and so bot and i was order to send this out
madmax765
Forum Member
 
Posts: 45
Joined: Tue Mar 18, 2008 2:11 pm
Location: U.S.

Re: User Reminder

Postby Aladdin » Wed Aug 06, 2008 4:54 pm

Hi,

I just installed this mod on my 3.0.2 board.

I enabled it and set to send automatic reminders to inactive users. How can I check that reminders have been sent? And when exactly will these reminders be sent? I checked my mail server's log and was not able to see any send attemps.

How does this mod work when is set to automatic mode? Thanks.
Aladdin
Newbie/Neuling
 
Posts: 9
Joined: Wed Aug 06, 2008 4:52 pm

Re: User Reminder

Postby Aladdin » Thu Aug 07, 2008 8:55 pm

lefty,

It seems that there is some kind of bug with select regarding inactive users part. Because as for now I have a following situation:

when I set automatic reminders for inactive users and when your script part from index.php is run - none of the user get their user_reminder_inactive column updated. It seems that script doesn't enter in while cycle. From that I assume that select returns no values.

I have no problems with "not logged in" and "zero post" parts. When script calls functions_user_reminder.php user_reminder_not_logged_in and user_reminder_zero_poster columns get updated with time values without any problems.

Can you look at the select under the following if condition:

if ( $config['user_reminder_inactive_enable'] == AUTOMATIC )
Aladdin
Newbie/Neuling
 
Posts: 9
Joined: Wed Aug 06, 2008 4:52 pm

Re: User Reminder

Postby Aladdin » Thu Aug 07, 2008 11:02 pm

One more addition:

Something is wrong with the following line

AND (u.user_lastvisit < " . $time . " OR session_time < " . $time . ")',

If I change this row to lets say

AND user_lastvisit < 1212957406', - this number is actual $time value - everything starts to work:/

But the following:

AND u.user_lastvisit < " . $time . "),

does not work at all:/

user_lastvisit number in my case is 1201866489 for the user I'm trying to play with.
Aladdin
Newbie/Neuling
 
Posts: 9
Joined: Wed Aug 06, 2008 4:52 pm

Re: User Reminder

Postby Aladdin » Fri Aug 08, 2008 10:03 am

And one more addition. I think that this line must be written as:

AND (u.user_lastvisit < ' . $time . ' OR session_time < ' . $time . ')',

When I changed your line to the line I mentioned above - all started to work.
Aladdin
Newbie/Neuling
 
Posts: 9
Joined: Wed Aug 06, 2008 4:52 pm

Re: User Reminder

Postby lefty » Sat Aug 09, 2008 3:59 pm

madmax765 wrote:Hi left i am curtenly using 0.2.1 i went and got your newest relase "user_reminder_1_0_1" so i went to folder user_reminder_1_0_1\user_reminder_1.0.1\contrib i open first file upgrade 021 to 100 to upgrade to 100 first before i went to upgrade 100 to 101, file upgrade 100 to 101 opens ok like the rest do,but file upgrade 021 to 100 dose not open right its all mesed up so i cant make heads or tails of what needs to be changed to go to next version, i even tryed to redown load it again just in case it was a bad down load, but its still curuped. Could you please fix then when you get time. Thank You

Oh where can i find the file that holds the info the reminder sends out. i like to change what it says, people are thinking im going to delete them. like to make it say like i am so and so bot and i was order to send this out

madmax, try to open it in Internet Explorer, this is a bug in FF.
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby lefty » Sat Aug 09, 2008 4:00 pm

alladin, i will look at your comments in the next couple of days, i only returned from an overnight flight today so looking at it now would be counterproductive i think ;)
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby Aladdin » Sun Aug 10, 2008 9:19 am

Let me know when you'll be able to check this:)

SO in general - problems were in inactive user section with this line:

AND (u.user_lastvisit < " . $time . " OR session_time < " . $time . ")',

When the line was changed to:

AND (u.user_lastvisit < ' . $time . ' OR session_time < ' . $time . ')',

all started to work.
Aladdin
Newbie/Neuling
 
Posts: 9
Joined: Wed Aug 06, 2008 4:52 pm

Re: User Reminder

Postby lefty » Sun Aug 10, 2008 11:28 pm

it should work the other way too.
what database are u using mysql?
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby Aladdin » Mon Aug 11, 2008 8:34 am

Believe in me it doesn't:) I'm using MYSQL 5.x on Debian etch with php5.

I had to debug two days and found out that this line caused problems in my case. But I'm not php and mysql guru so I contacted with my friend which knows these both things very well. And he told me that sql query is incorrect right after he looked at this part of query. I tried to bring out this query to text file when it was executed and saw that I'll paste here:

SELECT u.*, s.*, MAX(s.session_time) AS session_time FROM (phpbb_users u) LEFT JOIN phpbb_sessions s
ON (s.session_user_id = u.user_id) WHERE u.user_lastvisit > " . $time . " GROUP BY u.user_id ORDER BY u.user_lastvisit DESC

This is slightly modified query when I was debuging it:) But in general - with these quotes $time variable was left and this whole query was given to database as string. When I changed quotes I saw the following query:

SELECT u.*, s.*, MAX(s.session_time) AS session_time FROM (phpbb_users u) LEFT JOIN phpbb_sessions s ON (s.sessi
on_user_id = u.user_id) WHERE u.user_id <> '3'
AND u.user_type NOT IN (2, 1)
AND user_reminder_inactive = 0
AND user_allow_massemail = 1
AND (u.user_lastvisit < 1213224961 OR session_time < 1213224961) GROUP BY u.user_id ORDER BY
u.user_lastvisit DESC

And now all works without problems. But problems with query were only in inactive users script part. All other parts are working without problems.
Aladdin
Newbie/Neuling
 
Posts: 9
Joined: Wed Aug 06, 2008 4:52 pm

Re: User Reminder

Postby lefty » Mon Aug 11, 2008 8:16 pm

hi aladdin,
i looked at it a bit closer and i guess my understanding with double/single quote usage was not quite as advanced as i had thought it be :embarrassed:

i checked also with an expert who confirmed that my code should be slightly different.

if yours works now, leave it as is until i have issued the fix, for some odd reason, my old code works for me too.

should not be too long until i post this but i doubt i find the time to repackage all of this today.

good find, thanks very much :thumbsup:
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby Aladdin » Tue Aug 12, 2008 10:05 am

Can you explain how phpbb sends e-mail messages if I set manual reminders. I was able to see that board sends e-mail after 10 minutes when I set this reminder.
Aladdin
Newbie/Neuling
 
Posts: 9
Joined: Wed Aug 06, 2008 4:52 pm

Re: User Reminder

Postby lefty » Tue Aug 12, 2008 8:35 pm

try setting your email settings to 0.

otherwise, the emails are sent to the queue.

email.jpg
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby lefty » Thu Aug 21, 2008 10:36 pm


NOTE: Bugfind

There was a bugfind in the queries which apparently excluded the sql to run properly. Please replace includes/functions_user_reminder.php and includes/acp/acp_user_reminder.php with the files from this download: User Reminder Fix
Thanks to Aladdin and ups for the finds and evil3 for his help

I have not updated and repackaged the mod yet as i want to include an add log function for the automatic reminders.
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby lefty » Fri Aug 22, 2008 10:44 pm

lefty wrote:
NOTE: Bugfind

There was a bugfind in the queries which apparently excluded the sql to run properly. Please replace includes/functions_user_reminder.php and includes/acp/acp_user_reminder.php with the files from this download: User Reminder Fix
Thanks to Aladdin and ups for the finds and evil3 for his help

I have not updated and repackaged the mod yet as i want to include an add log function for the automatic reminders.

another bug :rant2: , the user_id's for banned users were getting cleared in the array. please redownload above User Reminder Fix...
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby Aladdin » Wed Aug 27, 2008 1:28 pm

Must I overwrite my old files with these new ones? Are you sure that everything is ok with double quotes this time?:) As I can see you query is not the same I have:)

Can you post exact changes made in these files? Thanks.
Aladdin
Newbie/Neuling
 
Posts: 9
Joined: Wed Aug 06, 2008 4:52 pm

Re: User Reminder

Postby lefty » Wed Aug 27, 2008 5:42 pm

yes, you will need to replace those two files with the new ones.

if you want to compare files in general, i woudl recommend to use winmerge.

for these changes you can look here:
http://trac2.assembla.com/lefty74_mods/changeset/112
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

Re: User Reminder

Postby J.P. » Thu Sep 04, 2008 2:51 pm

Hoi Lefty

Even een vraag in het nederlands.
Ik heb je mod geinstallerd en dan heb je in het beheerderspaneel de tap mod met daarin je mod.
Nu is het probleem dat als ik een moderator toegang geef tot gebruikers verwijderen dan krijgen ze die tab mod ook te zien.
Hoe kan ik kiezen wie het wel mag zien en wie niet?
Normaal kan ik het hier instellen maar daar staat jouw mod niet bij...
permissies ==> Globale permissies, Beheerders ==> selecteer de moderator groep ==> Stel de permissies in die je ze wilt geven...
J.P.
Newbie/Neuling
 
Posts: 5
Joined: Wed Jul 16, 2008 10:00 pm
Location: Netherlands, Groningen

Re: User Reminder

Postby lefty » Thu Sep 04, 2008 8:41 pm

I think i will add its own separate permissions for a future version.

for now, what you could do is open
includes/acp/info/acp_user_reminder.php

find all instances of
Code: Select all
'auth' => 'acl_a_user || acl_a_userdel'

and replace with
Code: Select all
'auth' => 'acl_a_user'


after that, you will need to re-add the modules.

I have not tested this but thinks this will do the trick...
lefty aka The Heikze! :eyebrowe:

Heiko Carstens
http://www.lefty74.com

Would you like me to install one of my mods for you? Read here for details
lefty
Abschlussklasse R10c
 
Posts: 1357
Joined: Mon Feb 06, 2006 1:20 am
Location: Den Haag - NL

PreviousNext

Return to [3.0.x] MOD Database Releases

Who is online

Users browsing this forum: No registered users and 2 guests

cron